Add new zeit online mobile app #7858
Merged
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simbiat
reviewed
Oct 9, 2024
|
You should also add these tests here Tests/Parser/Client/fixtures/mobile_app.yml. -
user_agent: Mozilla/5.0 (iPhone; CPU iPhone OS 17_7 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148 ZONApp/iOS/2.5.6;build:3000000110
client:
type: mobile app
name: ZEIT ONLINE
version: 2.5.6
-
user_agent: Mozilla/5.0 (Linux; Android 14; XQ-CC54 Build/65.2.A.2.179; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/128.0.6613.146 Mobile Safari/537.36 ZONApp/Android/2.2.7
client:
type: mobile app
name: ZEIT ONLINE
version: 2.2.7 |
vanetix
force-pushed
the
f/zeit-online-app
branch
from
0b0cde0
to
f4a6852
Compare
Thanks for that, I didn't notice those tests prior, and thanks for all the feedback! |
liviuconcioiu
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds a new mobile app by ZEIT Media, which is relatively new, but is just now showing up in our logs. Please let me know if there's anything else that's needed.
Review